bind_param: when value is nil, use String as default type #60
Open
lionelperrin wants to merge 1 commit intokubo:masterfrom
Open
bind_param: when value is nil, use String as default type #60lionelperrin wants to merge 1 commit intokubo:masterfrom
lionelperrin wants to merge 1 commit intokubo:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looking at DBD code, I've seen that when bind values are null, they are mapped using String as default type.
I don't know the drawback of this approach (reliability? performances?) but it is really convenient in many cases.
Why shouldn't we use String as default type when the value is nil and no type info is provided ?